Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToricVarieties] Tests for blowup do not depend on order of rays anymore #4353

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

HereAround
Copy link
Member

This PR aims to close #4348.

cc @lgoettgens @lkastner

@HereAround HereAround added topic: toric varieties testsuite Everything concerning testsuite labels Nov 26, 2024
Comment on lines 34 to 35
@test is_complete(amb1) == true
@test is_simplicial(amb1) == true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test is_complete(amb1) == true
@test is_simplicial(amb1) == true
@test is_complete(amb1)
@test is_simplicial(amb1)

I am not a fan of all of these == true here and further below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I removed those just now.

@lgoettgens
Copy link
Member

I would leave the question if that is mathematically sensible here to @lkastner and @benlorenz , since I do not really now whats going on here.

@HereAround
Copy link
Member Author

I would leave the question if that is mathematically sensible here to @lkastner and @benlorenz , since I do not really now whats going on here.

Mathematically, the only significant change is that I am asking for the rank of a matrix instead of comparing it against an explicit hard-coded form of that matrix (which depends on the order of the rays).

But then, fair.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (ba8f438) to head (2a96fc9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4353   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         649      649           
  Lines       86343    86345    +2     
=======================================
+ Hits        72797    72799    +2     
  Misses      13546    13546           

see 1 file with indirect coverage changes

@HereAround HereAround enabled auto-merge (rebase) November 26, 2024 18:51
@benlorenz
Copy link
Member

In the log in #4348 there is a second failure which is probably related:

Properties of toric blowup defined by ideal: Test Failed at /home/runner/work/Oscar.jl/Oscar.jl/test/AlgebraicGeometry/ToricVarieties/toric_blowups.jl:76
  Expression: II == center_unnormalized(bl)
   Evaluated: Sheaf of ideals on normal, smooth toric variety without torusfactor == Sheaf of ideals on normal, smooth toric variety without torusfactor

@HereAround HereAround merged commit 43d0c68 into oscar-system:master Nov 27, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsuite Everything concerning testsuite topic: toric varieties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests in ToricVarieties/toric_blowups.jl depend on order of rays(normal_fan(simplex(2)))
4 participants